Scripts: Pin the @wordpress/scripts version to a version supported by 6.5 #62234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 924e1cf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9349833838
|
ellatrix
approved these changes
Jun 4, 2024
|
@ellatrix we can't because the new transform only works in WP 6.6 (which is not released yet) and also most plugins want to support both 6.6 and 6.5 at least. |
|
Right. Will the old create-block work with 6.6 (and GB)? |
|
@ellatrix yes |
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
ellatrix
added a commit
that referenced
this pull request
Jun 11, 2024
… WP 6.5 (#62234) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
ellatrix
added a commit
that referenced
this pull request
Jun 11, 2024
… WP 6.5 (#62234) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
… WP 6.5 (WordPress#62234) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
|
I opened a follow-up to remove the limitation for the version used for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #62202
What?
WordPress 6.6 was updated to use the new JSX transform but it's not released yet. That said, the latest version of the wp-scripts package targets 6.6 (and the Gutenberg plugin) by default and it's used to build Gutenberg itself so it was updated to use the new JSX.
For this reason, we need to pin the
@wordpress/create-blocktool to a version of wp-scripts that is supported by WordPress 6.5.Testing Instructions
1 : Create a new wordpress plugin "npx ../path-to-gutenberg-clone/packages/create-block"
2: cd test-plugin
3 : npm start
3 : activate plugin test-plugin
4 : edit a new page in wp-admin
5 : try to add the new block "/test-plugin"
6: The block should appear.